Remove the legacy navigation components #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d9e29f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #2353 +/- ##
==========================================
- Coverage 96.97% 96.81% -0.17%
==========================================
Files 252 228 -24
Lines 20273 19016 -1257
Branches 1263 1172 -91
==========================================
- Hits 19660 18410 -1250
+ Misses 600 593 -7
Partials 13 13 |
connor-baer
force-pushed
the
chore/remove-sidebar
branch
from
3f19edb to
a7e4653
Compare
connor-baer
force-pushed
the
chore/remove-sidebar
branch
from
a7e4653 to
d9e29f2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Header and Sidebar components have been superseded by the TopNavigation and SideNavigation components. They stopped being updated and were marked as legacy in v7. They need to be removed in the next major since they rely on the legacy color tokens which will be removed from the design tokens in this major.
Approach and changes
Definition of done